-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: adds support for new "selector" API #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Currently the Trans componant has this defaultValue: |
Like I mentioned earlier, I don't have time to look at this right now—feel free to go ahead without me. |
@VIKTORVAV99 can you also have a look at this? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closes #1758
This PR accompanies i18next/#2322.
What this PR changes
To keep the review of this PR simple, I figured it would help if I talked about the changes, since the actual change is quite small.
Here's a simplified version of what this PR does:
Essentially all this PR does is adds an inline check for whether
enableSelector
is turned on; if so, it processes the tree of translations, rather than generation a union of strings.Checklist
npm run test
Checklist (for documentation change)